fix: skip event recording without execution id#828
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Skips best-effort pipeline event recording when a pipeline is executed without an ExecutionID, preventing noisy warnings for inline/untracked pipeline executions while keeping pipeline execution behavior unchanged.
Changes:
- Guard
Pipeline.recordEventto return early whenExecutionID == ""(in addition toEventRecorder == nil). - Add regression test coverage ensuring pipelines still execute successfully and do not attempt recorder calls when
ExecutionIDis empty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| module/pipeline_executor.go | Skips event recording when the pipeline has no ExecutionID. |
| module/pipeline_event_recording_test.go | Adds regression test for empty ExecutionID to ensure no recorder calls occur and execution still succeeds. |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #822
Verification
GOWORK=off go test ./module -run TestPipeline_EventRecorder_EmptyExecutionIDSkipsRecording -count=1failed with recorder calls usingexecution_id=""andparse execution ID "": invalid UUID length: 0warnings.GOWORK=off go test ./module -run TestPipeline_EventRecorder_EmptyExecutionIDSkipsRecording -count=1passed.GOWORK=off go test ./module -count=1git diff --check