Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions engine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,49 @@ func TestEngineTriggerWorkflow_RedactsSensitiveResultsInDebugLogs(t *testing.T)
}
}

func TestEngineTriggerWorkflow_RedactsSensitiveResultHeadersInDebugLogs(t *testing.T) {
app := newMockApplication()
engine := NewStdEngine(app, app.Logger())
loadAllPlugins(t, engine)

handler := &mockWorkflowHandler{
name: "mock.handler",
handlesFor: []string{"header-result-workflow"},
results: map[string]any{
"headers": map[string]any{
"Authorization": "Bearer jwt.secret.value",
"Cookie": "sid=session-secret",
"Set-Cookie": "sid=session-secret; HttpOnly",
"X-API-Key": "api-secret",
"Content-Type": "application/json",
},
},
}
engine.RegisterWorkflowHandler(handler)

holder := &module.PipelineResultHolder{}
ctx := context.WithValue(context.Background(), module.PipelineResultContextKey, holder)
if err := engine.TriggerWorkflow(ctx, "header-result-workflow", "run", map[string]any{}); err != nil {
t.Fatalf("TriggerWorkflow failed: %v", err)
}

logText := strings.Join(app.logger.logs, "\n")
for _, leaked := range []string{"jwt.secret.value", "session-secret", "api-secret"} {
if strings.Contains(logText, leaked) {
t.Fatalf("debug logs leaked sensitive header value %q:\n%s", leaked, logText)
}
}
if !strings.Contains(logText, module.RedactionPlaceholder) {
t.Fatalf("debug logs should include redaction placeholder, got:\n%s", logText)
}

raw := holder.Get()
headers := raw["headers"].(map[string]any)
if headers["Authorization"] != "Bearer jwt.secret.value" {
t.Fatalf("pipeline result holder must preserve raw Authorization header, got %#v", headers["Authorization"])
}
}

func TestEngineTriggerWorkflow_RedactsSensitiveInputInDebugLogs(t *testing.T) {
app := newMockApplication()
engine := NewStdEngine(app, app.Logger())
Expand Down
3 changes: 3 additions & 0 deletions module/step_output_redactor.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ var SensitiveFieldPatterns = []string{
"password",
"token",
"credential",
"authorization",
"cookie",
"api_key",
"api-key",
"apikey",
"private_key",
"access_key",
Expand Down
27 changes: 27 additions & 0 deletions module/step_output_redactor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,33 @@ func TestRedactStepOutput_NestedMaps(t *testing.T) {
}
}

func TestRedactStepOutput_NestedSensitiveHeaders(t *testing.T) {
output := map[string]any{
"headers": map[string]any{
"Authorization": "Bearer jwt.secret.value",
"Cookie": "sid=session-secret",
"Set-Cookie": "sid=session-secret; HttpOnly",
"X-API-Key": "api-secret",
"X-Scenario90-Seed-Token": "seed-secret",
"Content-Type": "application/json",
},
}

got := RedactStepOutput(output)
headers, ok := got["headers"].(map[string]any)
if !ok {
t.Fatalf("headers should remain a map, got %T", got["headers"])
}
for _, key := range []string{"Authorization", "Cookie", "Set-Cookie", "X-API-Key", "X-Scenario90-Seed-Token"} {
if headers[key] != RedactionPlaceholder {
t.Fatalf("%s should be redacted, got %#v", key, headers[key])
}
}
if headers["Content-Type"] != "application/json" {
t.Fatalf("Content-Type should be preserved, got %#v", headers["Content-Type"])
}
}

func TestRedactStepOutput_NestedSlices(t *testing.T) {
output := map[string]any{
"rows": []any{
Expand Down
Loading