docs: clarify DNS ownership policy#821
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Documents and clarifies the cross-provider DNS ownership enforcement mechanism for infra.dns, centering on wfctl dns-policy and the _workflow-dns-policy.<zone> TXT policy record used during wfctl infra apply.
Changes:
- Adds an “Ownership policy” section describing zone-level policy storage, delegation semantics, and
WORKFLOW_DNS_OWNERenforcement behavior. - Provides CLI examples for showing, setting, and transferring DNS policy ownership.
- Records operational rules (fail-closed policy reads, SOA/NS protection, sanitizer preservation).
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wfctl dns-policyownership mechanism forinfra.dns_workflow-dns-policy.<zone>supersedes the older per-record_dns-managed-byideaWORKFLOW_DNS_OWNER, fail-closed policy reads, SOA/NS protection, and policy preservationPartially addresses #779 by documenting/narrowing the DNS ownership portion. The remaining generic cloud-resource tag/label ownership convention still needs a separate implementation pass.
Verification
git diff --check