ci(iac/admin): vendored infra.proto staleness gate (#21)#808
Merged
Conversation
Adds scripts/check-vendored-proto.sh and .github/workflows/proto-vendor-staleness.yml to catch upstream drift in iac/admin/testdata/infra.proto. How the script works: 1. Reads '// Source version: <tag>' from the vendored file header 2. Fetches the upstream proto from GoCodeAlone/workflow-plugin-infra@<tag> via the GitHub raw API (no local checkout required) 3. Extracts the *Config message name sets from both files 4. Diffs them; exit 1 + operator-readable error if any message was added or removed (with 'make vendor-infra-proto' refresh instructions) Verified locally: bash scripts/check-vendored-proto.sh → exit 0 (in-sync) (mutate proto) && bash ... → exit 1 (drift detected) actionlint proto-vendor-staleness.yml → exit 0 (no YAML issues) The CI job runs on push/PR to main when the proto or script changes, plus a weekly cron to catch upstream drift even when the local file is not touched. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… parity test Per spec-reviewer cosmetic suggestion: explain that *Config message scope is intentional — matches catalog_proto_parity_test.go surface. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…onfig_messages \+ is a GNU BRE extension unsupported by BSD sed; -E with + works on both macOS and Linux. CI (ubuntu-latest) was correct either way; this fixes local dev experience on macOS. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR-2 of the infra-admin v1.1 program (#21 from the v1 deferred-followup queue). Adds a CI gate that fails when
workflow's vendorediac/admin/testdata/infra.protodescriptor drifts from upstreamworkflow-plugin-infra— closing the cross-repo proto-vendor staleness gap the v1 catalog parity test depends on.Changes
.github/workflows/proto-vendor-staleness.yml— CI job that runs the staleness check.scripts/check-vendored-proto.sh— exits non-zero when the vendored proto's message set drifts; reuses the v1catalog_proto_parity_testsurface + Makefile refresh target.Verification
bash scripts/check-vendored-proto.sh→ exit 0 (in-sync).actionlintclean. Independent of PR-1 (workflow#807) — touches only CI + the vendored proto check. Rollback: revert the workflow file (no runtime impact).🤖 Generated with Claude Code