chore(deps): bump GoCodeAlone/modular to latest + docker CVE risk-acceptance#793
Merged
Conversation
Updates all modular dependencies to the freshly-released versions: modular v1.13.0 -> v1.13.4 modules/auth v1.15.0 -> v1.17.0 modules/cache v1.15.0 -> v1.17.0 modules/eventbus/v2 v2.8.0 -> v2.10.0 (includes #112 eventbus timer-drain + observability fix) modules/jsonschema v1.15.0 -> v1.17.0 modules/reverseproxy/v2 v2.8.0 -> v2.10.0 (fsnotify v1.9.0 -> v1.10.1 pulled transitively.) Also records ADR 0015 accepting the 29 github.com/docker/docker Dependabot alerts as tolerable_risk: v28.5.2 is the latest go-importable version (the 29.3.1 fix is not published as a Go module), and all five advisories are moby daemon-side CVEs not reachable through this project's client-only usage. The alerts have been dismissed; the ADR documents the reasoning and follow-up. go build ./... passes; the broad test suite passes (the only local failures are the environment-dependent wfctl CLI/CI tooling tests, unrelated to this bump).
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
The CI go-mod-tidy job runs 'go mod tidy' in example/ (which uses replace github.com/GoCodeAlone/workflow => ../) and fails on any diff. After bumping the root module's modular deps, example/go.mod must be re-tidied to v1.13.4 + the matching module versions.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The verify_capabilities/* and conformance/* testdata plugin fixtures use 'replace github.com/GoCodeAlone/workflow => ../../../../..', so bumping the root module's modular deps to v1.13.4 made their go.mod/go.sum inconsistent. Under the test's 'go build -mod=readonly' this surfaced as 'updates to go.mod needed' and failed TestVerifyCapabilities_*/TestFallbackRuns. go mod tidy across all 10 fixtures realigns them to v1.13.4; cmd/wfctl tests pass locally (ok, 56s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates all
GoCodeAlone/modulardependencies to the freshly-released versions:(fsnotify v1.9.0→v1.10.1 transitive.)
go build ./...passes; broad test suite passes locally (only env-dependent wfctl CLI/CI tooling tests fail locally, unrelated to this bump — CI is the arbiter).Also records ADR 0015 accepting the 29
github.com/docker/dockerDependabot alerts as tolerable_risk: v28.5.2 is the latest go-importable version (the 29.3.1 fix is not published as a Go module) and all five advisories are moby daemon-side CVEs not reachable through this project's client-only usage. The alerts have been dismissed.