fix(wfctl): add log follow completion grace#749
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a client-side “completion grace” window to wfctl logs capture --follow --duration … so bounded log capture sessions can finish cleanly (EOF) instead of racing the RPC deadline, while keeping the provider-side follow duration unchanged.
Changes:
- Extend the
CaptureLogscall context timeout by a fixed 30s grace beyond the requested--duration. - Add regression test coverage asserting the provider sees a deadline that exceeds the requested follow duration, while
DurationSecondsremains unchanged.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cmd/wfctl/logs.go |
Adds a 30s client-side grace to the follow context timeout without changing the provider request duration. |
cmd/wfctl/logs_test.go |
Adds a regression test that inspects the provider’s context deadline/remaining time to validate the grace behavior. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification