feat(wfctl): add infra logs alias#747
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds wfctl infra logs as a convenience alias for the existing provider log capture functionality (wfctl logs capture), making log capture discoverable under the infra command group while keeping the original logs command behavior unchanged.
Changes:
- Add
wfctl infra logsdispatcher wiring and help text entry. - Implement
runInfraLogsto routeinfra logs [capture] ...to the existingrunLogsCapturebehavior. - Add wfctl tests to cover the new alias and update infra usage expectations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/wfctl/logs.go | Adds runInfraLogs alias handler that forwards to runLogsCapture. |
| cmd/wfctl/infra.go | Wires new infra logs action into infra subcommand dispatch and usage output. |
| cmd/wfctl/logs_test.go | Adds a test ensuring wfctl infra logs uses provider log capture and forwards key request fields. |
| cmd/wfctl/infra_env_integration_test.go | Updates infra usage test to expect the new logs action to be documented. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wfctl infra logsas an alias for provider log capturewfctl logs captureunchangedValidation
GOWORK=off go test ./cmd/wfctl -run 'TestInfraLogsAliasUsesProviderLogCapture|TestInfraUsageDocumentsConfigAwareImportFlags' -count=1GOWORK=off go test ./cmd/wfctl ./interfaces ./plugin/external/proto ./plugin/external/sdkGOWORK=off go build -o /tmp/wfctl-infra-logs ./cmd/wfctlDIGITALOCEAN_TOKENis set:digitalocean: missing required config key 'token'