fix(wfctl): capture logs for env resource name#739
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes wfctl logs capture so that when an infra module is resolved for a specific environment (via ResolveForEnv), the resulting ResourceSpec preserves the env-resolved resource name (including “lifted” config.name for infra.* modules). This ensures log capture requests target the correct cloud resource name in env-specific configurations.
Changes:
- Preserve
ResolveForEnv(...).Namewhen building the log-captureResourceSpec. - Add a regression test covering env-specific renaming for
infra.container_service.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/wfctl/logs.go | Uses the env-resolved module name when constructing the ResourceSpec for log capture. |
| cmd/wfctl/logs_test.go | Adds a regression test verifying env-resolved resource names are used for log capture. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification