feat: allow infra apply to skip bootstrap#713
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a --skip-bootstrap flag to wfctl infra apply to allow operators to skip the auto-bootstrap step when required secrets/state already exist, while preserving the default auto-bootstrap behavior.
Changes:
- New
--skip-bootstrapboolean flag wired intorunInfraApply, which gates theautoBootstrapdecision. - Documentation updates in
docs/WFCTL.mdand the embedded DSL reference describing the flag and its intended use. - New regression test
TestInfraApplyPlanSkipBootstrapverifying the--plan+--skip-bootstrappath withinfra.auto_bootstrap: true.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/wfctl/infra.go | Adds --skip-bootstrap flag and incorporates it into the autoBootstrap predicate. |
| cmd/wfctl/infra_apply_plan_test.go | New test ensuring --skip-bootstrap bypasses bootstrap on the --plan apply path. |
| docs/WFCTL.md | Documents the new flag in the apply usage and options table. |
| cmd/wfctl/dsl-reference-embedded.md | Adds guidance on appropriate usage of --skip-bootstrap. |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wfctl infra apply --skip-bootstrapfor scoped/operator applies where required secrets and state already exist--planapply withinfra.auto_bootstrap: trueand skipped bootstrapValidation
GOWORK=off go test ./cmd/wfctl -run 'TestInfraApply|TestParseInfraConfig_AutoBootstrap|TestInfraApplyPlanSkipBootstrap|TestInfraApplyConsumesPlan' -count=1GOWORK=off go test ./config -run 'Test.*AutoBootstrap|TestRoundTrip' -count=1GOWORK=off go build ./cmd/wfctlgit diff --check