fix(wfctl): preserve iac provider plan metadata#710
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates wfctl plugin installation so registry-provided IaC provider metadata survives the plugin.json rewrite performed during install, addressing missing iacProvider.computePlanVersion warnings for v2 IaC plugins.
Changes:
- Adds top-level
iacProvidersupport to registry and installed manifest models. - Persists registry
iacProvidermetadata into installed plugin.json. - Adds a regression test for preserving
computePlanVersion.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
cmd/wfctl/plugin_registry.go |
Extends registry manifest structs for top-level IaC provider metadata. |
cmd/wfctl/plugin_install.go |
Writes top-level IaC provider metadata into installed plugin.json. |
cmd/wfctl/plugin_install_e2e_test.go |
Adds regression coverage for preserving computePlanVersion. |
| Keywords []string `json:"keywords,omitempty"` | ||
| Homepage string `json:"homepage,omitempty"` | ||
| Capabilities *RegistryCapabilities `json:"capabilities,omitempty"` | ||
| IaCProvider *RegistryIaCProvider `json:"iacProvider,omitempty"` |
| ResourceTypes []string `json:"resourceTypes,omitempty"` | ||
| ComputePlanVersion string `json:"computePlanVersion,omitempty"` | ||
| } | ||
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification