Accept engine pseudo-versions in plugin evidence#631
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates wfctl’s plugin compatibility evidence model to allow engine versions (only) to be recorded as Go pseudo-versions, enabling conformance CI to pin an exact post-release engine commit while keeping plugin release versions strictly MAJOR.MINOR.PATCH.
Changes:
- Extend
CanonicalEngineVersionto accept either strict semver or a pseudo-version-like semver form. - Keep
CanonicalPluginVersionstrict (release-only) and add a regression test rejecting pseudo-versions for plugins. - Add test coverage for engine pseudo-version canonicalization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cmd/wfctl/plugin_compat_model.go |
Adds pseudo-version acceptance logic for engine version canonicalization. |
cmd/wfctl/plugin_compat_model_test.go |
Adds tests covering engine pseudo-versions and ensures plugin versions still reject pseudo-versions. |
intel352
force-pushed
the
codex/plugin-conformance-pseudo-version
branch
from
a9010b7 to
4ce86b7
Compare
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CanonicalEngineVersionto accept Go pseudo-versions such asv0.51.3-0.20260511085732-8246535de8bdWhy
Plugin conformance CI may need to pin a post-release workflow commit before the next tagged release. Evidence should record the exact engine build under test instead of pretending it was the prior release.
Verification
GOWORK=off go test ./cmd/wfctl -run 'TestPluginCompatVersion|TestPluginConformanceLocalJSONPass' -count=1GOWORK=off go test ./cmd/wfctl -run 'TestPluginCompat|TestPluginConformance' -count=1git diff --checkReview
Manual antagonistic pass: checked that only engine versions accept pseudo-version shape;
CanonicalPluginVersionstill rejects pseudo-versions.