ci: generate wfctl-centered build jobs#590
Merged
Merged
Conversation
Use wfctl ci run and wfctl build in generated CI instead of raw go test/go build commands. Antagonistic review removed default publish behavior to keep generated jobs validation-only.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates wfctl ci generate’s produced GitHub Actions / GitLab CI build jobs to “dogfood” wfctl for running tests and builds, instead of invoking raw go test / go build directly. This aligns CI generation with the project’s portable lifecycle commands and keeps the generated pipelines focused on build/test (no pushes).
Changes:
- GitHub Actions build workflow now installs
wfctl, runswfctl ci run --phase test, thenwfctl build --no-push. - GitLab CI build job similarly installs
wfctland useswfctlfor test/build steps. - Generator tests updated to assert the new
wfctl-based commands are present and oldgo build ./...is absent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cmd/wfctl/ci.go | Adjusts generated CI templates to install and use wfctl for test/build phases. |
| cmd/wfctl/ci_test.go | Updates tests to validate the new wfctl-based CI template output. |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Boundary notes