fix(wfctl): R-A4 align rule consults top-level secrets block#562
Closed
Copilot wants to merge 2 commits into
Closed
fix(wfctl): R-A4 align rule consults top-level secrets block#562Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
Copilot
AI
changed the title
[WIP] Fix R-A4 align rule to consult top-level secrets for key generation
fix(wfctl): R-A4 align rule consults top-level secrets block
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkRA4checked${VAR}references inenv_varsagainstctx.secretKeys, butctx.secretKeyswas only populated from module-formsecrets.generate— not the top-levelsecrets:block. Any config using the canonical top-level form would produce spurious R-A4 FAILs at align time, forcing unnecessary secret exports in CI just to pass validation.Changes
buildAlignContext(infra_align_rules.go): whencfg.Secrets != nil, populatectx.secretKeysfrom bothcfg.Secrets.Generate(bykey) andcfg.Secrets.Entries(byname) — the same loop that already setsctx.secretGensfor R-A9processImports(config/config.go): merges top-levelsecrets.generateandsecrets.entriesfrom imported files so keys declared in shared/imported configs are also visible to R-A4infra_align_test.go): three new cases covering top-levelsecrets.generate, top-levelsecrets.entries, and secrets declared in an imported file