fix(migrations): parseMigrationStatus accepts fresh-database output without explicit Dirty line#545
Merged
Merged
Conversation
…ne in atlas driver Agent-Logs-Url: https://github.com/GoCodeAlone/workflow/sessions/53efbe3a-acca-4b90-b019-e60fb1112c6a Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix panic on apply for atlas driver
fix(migrations): parseMigrationStatus accepts fresh-database output without explicit Dirty line
May 5, 2026
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes wfctl migrations validate baseline-candidate validation for fresh databases when the atlas migration driver outputs No migrations applied. without an explicit Dirty: line, by inferring dirty=false for that sentinel state so the status output is no longer treated as incomplete.
Changes:
- Update
parseMigrationStatusto treatNo migrations applied.as implicitly clean (dirtySeen=true,Dirty=false) when noDirty:line is present. - Add unit tests covering text and JSON fresh-database status parsing (including
pending: []andpending: null). - Add an integration-style test covering the baseline-candidate validation flow with atlas-style fresh-database status output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/wfctl/migrations_baseline.go | Infers dirty=false for the No migrations applied. sentinel to avoid rejecting fresh-database status output that omits Dirty:. |
| cmd/wfctl/migrations_baseline_test.go | Adds unit + integration coverage to ensure fresh-database status parsing/validation succeeds with and without an explicit Dirty: line. |
Agent-Logs-Url: https://github.com/GoCodeAlone/workflow/sessions/4aba00f5-c1a5-42d7-bb58-7af52a167cf2 Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Contributor
Author
The CI failure was caused by 33 pre-existing lint issues from the golangci-lint v2.12.1 upgrade (tracked in issue #516). Fixed in commit
|
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The atlas driver (via
workflow-migrate) omits the"Dirty:"line when outputting"No migrations applied."for a fresh database.parseMigrationStatusrequired an explicitdirtySeenflag, causing it to reject valid fresh-database status as"incomplete migration status output"— failing baseline-candidate validation even after the atlas executor panic (the primary CI blocker) was fixed in the binary.Changes
cmd/wfctl/migrations_baseline.go—parseMigrationStatus: when"No migrations applied."is seen, implicitly setdirtySeen = truewithdirty = false. A fresh database cannot be dirty (no migration has been attempted), so the inference is always safe. An explicit subsequent"Dirty: true"line can still override it.cmd/wfctl/migrations_baseline_test.go— adds:TestParseMigrationStatusFreshDatabaseNoMigrationsApplied: unit tests for text-format (with/without explicitDirty:line) and JSON (pending: [],pending: null)TestRunMigrationsValidateAtlasFreshDatabaseStatusWithoutDirtyLine: integration test for the full baseline-candidate validation flow returning atlas-style fresh-database status