ci: use Node 24 cache action for registry Go jobs#239
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the registry’s GitHub Actions workflows to avoid actions/setup-go’s implicit cache path (which uses an older Node runtime) and instead uses an explicit, pinned actions/cache@v5 (Node 24) step for Go build/module caching, while leaving the existing wfctl validation/sync behavior intact.
Changes:
- Disable
actions/setup-gobuilt-in caching (cache: false) for the affected Go jobs. - Add an explicit Go cache step using
actions/cache@v5.0.5pinned by SHA, caching~/.cache/go-buildand~/go/pkg/mod. - Keep existing checkout / wfctl steps and behavior unchanged, including the plugin-filtered sync flow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/validate.yml | Replaces setup-go caching with an explicit actions/cache@v5.0.5 step for the core-manifest validation Go job. |
| .github/workflows/sync-registry-manifests.yml | Replaces setup-go caching with an explicit actions/cache@v5.0.5 step for the Go-dependent sync path, preserving existing conditional execution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/cache@v4pathactions/cache@v5.0.5pinned by SHA for Go module/build cacheVerification
bash scripts/validate-manifests.shbash tests/test-build-index.shbash tests/test-schema-allowlist-coverage.shbash tests/test-sync-workflow-token.shbash tests/test-build-pages-release-token.shactionlint .github/workflows/*.ymlgit diff --check