Skip to content

chore: apply plugin version discipline#15

Merged
intel352 merged 3 commits into
mainfrom
issue-760-version-discipline
Jun 1, 2026
Merged

chore: apply plugin version discipline#15
intel352 merged 3 commits into
mainfrom
issue-760-version-discipline

Conversation

@intel352
Copy link
Copy Markdown
Contributor

@intel352 intel352 commented Jun 1, 2026

Part of GoCodeAlone/workflow#760.

Changes:

  • keep committed plugin.json.version at the 0.0.0 development sentinel
  • remove the obsolete sync-plugin-version workflow when present
  • add post-build release validation so the shipped manifest is checked against the tag
  • preserve/strengthen runtime capability checks where needed

Verification:

  • wfctl plugin validate-contract .
  • wfctl plugin validate-contract --for-publish --tag v9.9.9 .
  • GOWORK=off go test ./...

Copilot AI review requested due to automatic review settings June 1, 2026 18:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens release/version discipline for the ws-auth plugin by keeping the repository manifest at a development sentinel version, removing an obsolete version-sync workflow, and adding release-time validation to ensure published artifacts match the release tag.

Changes:

  • Set plugin.json’s committed version to the 0.0.0 development sentinel.
  • Remove the sync-plugin-version GitHub Actions workflow that auto-opened PRs on tag pushes.
  • Add a post-build wfctl plugin validate-contract --for-publish check in the release workflow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
plugin.json Pins committed manifest version to 0.0.0 as a dev sentinel.
.github/workflows/sync-plugin-version.yml Removes the obsolete tag-triggered manifest-sync PR workflow.
.github/workflows/release.yml Adds post-build validation intended to verify released artifacts against the tag.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml Outdated
"${{ runner.temp }}/wfctl-bin/wfctl" plugin verify-capabilities --binary "$BIN" .
- name: Verify shipped plugin.json carries tag (post-build)
run: |
"${{ runner.temp }}/wfctl-bin/wfctl" plugin validate-contract --for-publish --tag ${{ github.ref_name }} --release-dir . .
@intel352 intel352 merged commit 2be27fe into main Jun 1, 2026
4 checks passed
@intel352 intel352 deleted the issue-760-version-discipline branch June 1, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants