chore: apply plugin version discipline#20
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies “version discipline” for the Twilio workflow plugin by keeping the repo’s plugin.json at a development sentinel version, removing the old tag-sync workflow, and adding a release-time validation to ensure the shipped manifest matches the release tag.
Changes:
- Set committed
plugin.json.versionto0.0.0(development sentinel). - Remove the obsolete
.github/workflows/sync-plugin-version.ymlworkflow. - Add a post-build
wfctl plugin validate-contractcheck intended to validate the release output against the tag.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
plugin.json |
Sets the committed manifest version to the 0.0.0 development sentinel. |
.github/workflows/sync-plugin-version.yml |
Removes the tag-driven PR workflow that previously synced plugin.json version. |
.github/workflows/release.yml |
Adds a post-build validation step to check published artifacts/manifest against the tag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "${{ runner.temp }}/wfctl-bin/wfctl" plugin verify-capabilities --binary "$BIN" . | ||
| - name: Verify shipped plugin.json carries tag (post-build) | ||
| run: | | ||
| "${{ runner.temp }}/wfctl-bin/wfctl" plugin validate-contract --for-publish --tag ${{ github.ref_name }} --release-dir . . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of GoCodeAlone/workflow#760.
Changes:
Verification: