ci: canonical registry notify (fix dead dispatch + drop manifest-overwrite)#11
Merged
Conversation
Replace the old notify-registry job (REGISTRY_PAT + full github.repository
payload) with the fleet-canonical notify-workflow-registry job: pinned
peter-evans/repository-dispatch@v4 SHA, repo_dispatch_token secret, bare
plugin name payload {"plugin":"teams",...}, and pre-release filter
(!contains(github.ref_name,'-')).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the release workflow to notify the canonical GoCodeAlone/workflow-registry via a pinned repository-dispatch (v4 SHA), using the expected payload shape ({"plugin":"teams","tag":...}) and guarding against pre-release tags.
Changes:
- Replaces the legacy
notify-registryjob withnotify-workflow-registrythat targetsGoCodeAlone/workflow-registry. - Pins
peter-evans/repository-dispatchto a v4 commit SHA and switches tosecrets.repo_dispatch_token. - Adds guards to avoid dispatching on deleted tags, pre-release tags, or non-canonical forks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+59
to
61
| - name: Trigger registry manifest sync | ||
| uses: peter-evans/repository-dispatch@28959ce8df70de7be546dd1250a005dd32156697 # v4 | ||
| with: |
Prior commit dropped the whole notify-registry job (which also held verify-capabilities + the draft->non-draft Publish step). Restore them (job renamed notify-registry -> publish-release), keep only the broken dispatch removed, add canonical notify-workflow-registry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the old
notify-registryjob that usedREGISTRY_PATand sent the fullgithub.repositorystring as the plugin identifier with the fleet-canonicalnotify-workflow-registryjob.Changes:
notify-registryjob (REGISTRY_PAT secret, wrong payload shape, stalepeter-evans/repository-dispatch@v3)notify-workflow-registrywith pinned SHA (@28959ce8df70de7be546dd1250a005dd32156697= v4),repo_dispatch_tokensecret, bare plugin name payload{"plugin":"teams",...}, and pre-release guard (!contains(github.ref_name, '-'))Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com