Skip to content

chore: apply plugin version discipline#17

Merged
intel352 merged 1 commit into
mainfrom
issue-760-version-discipline
Jun 1, 2026
Merged

chore: apply plugin version discipline#17
intel352 merged 1 commit into
mainfrom
issue-760-version-discipline

Conversation

@intel352

@intel352 intel352 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Part of GoCodeAlone/workflow#760.

Changes:

  • keep committed plugin.json.version at the 0.0.0 development sentinel
  • remove the obsolete sync-plugin-version workflow when present
  • add post-build release validation so the shipped manifest is checked against the tag

Verification:

  • wfctl plugin validate-contract .
  • wfctl plugin validate-contract --for-publish --tag v9.9.9 .
  • GOWORK=off go test ./...

Copilot AI review requested due to automatic review settings June 1, 2026 17:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enforces “plugin version discipline” by keeping the repo’s committed plugin.json at a development sentinel version while shifting release-time correctness checks into the release workflow (and removing the prior tag-triggered sync workflow).

Changes:

  • Set committed plugin.json.version to 0.0.0 (development sentinel).
  • Remove the obsolete sync-plugin-version GitHub Actions workflow.
  • Add a post-build wfctl plugin validate-contract step intended to validate the shipped manifest against the release tag.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
plugin.json Sets the committed manifest version to the 0.0.0 development sentinel.
.github/workflows/sync-plugin-version.yml Removes the tag-driven workflow that previously opened PRs to sync plugin.json version.
.github/workflows/release.yml Adds post-build validation intended to ensure the released manifest matches the tag.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml
@intel352 intel352 merged commit ace8527 into main Jun 1, 2026
5 checks passed
@intel352 intel352 deleted the issue-760-version-discipline branch June 1, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants