Skip to content

refactor: use compute-core task proof sdk#16

Merged
intel352 merged 3 commits into
mainfrom
feat/consume-compute-core-sdk
Jun 6, 2026
Merged

refactor: use compute-core task proof sdk#16
intel352 merged 3 commits into
mainfrom
feat/consume-compute-core-sdk

Conversation

@intel352
Copy link
Copy Markdown
Contributor

@intel352 intel352 commented Jun 6, 2026

Summary

  • replace private workflow-compute protocol imports with workflow-plugin-compute-core/protocol
  • remove the duplicate local compute HTTP client and use protocol.Client
  • add a dependency-boundary test so product-capture does not regress to private workflow-compute types

Verification

  • GOWORK=off go test ./... -count=1
  • git diff --check

RED/GREEN Evidence

With the boundary test before the import swap:

GOWORK=off go test . -run TestProductCaptureUsesPublicComputeCoreSDK -count=1
FAIL - product-capture must not depend on private workflow-compute; use workflow-plugin-compute-core

With the fix restored:

GOWORK=off go test . -run TestProductCaptureUsesPublicComputeCoreSDK -count=1
ok github.com/GoCodeAlone/workflow-plugin-product-capture

Copilot AI review requested due to automatic review settings June 6, 2026 06:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the product-capture plugin to depend on the public workflow-plugin-compute-core protocol SDK instead of private workflow-compute types, while removing the locally duplicated compute HTTP client and adding a guardrail test to prevent regressions.

Changes:

  • Swap protocol imports from workflow-compute/pkg/protocol to workflow-plugin-compute-core/protocol.
  • Replace the custom computeClient with protocol.Client and update call sites accordingly.
  • Add a dependency-boundary test to enforce the public SDK dependency and prevent reintroducing the local client.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
module_dependency_test.go Adds a boundary test to prevent private compute dependencies and local client duplication.
internal/plugin/step.go Switches step execution to use protocol.Client and exported SDK methods.
internal/plugin/sign.go Updates protocol import to compute-core SDK.
internal/plugin/plugin_test.go Updates protocol import used by plugin tests.
internal/plugin/client.go Removes the duplicated local compute HTTP client implementation.
go.mod Replaces workflow-compute dependency with workflow-plugin-compute-core and updates indirect requirements.
go.sum Updates sums to reflect the dependency swap.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread module_dependency_test.go Outdated
Comment thread module_dependency_test.go Outdated
@intel352 intel352 merged commit d016119 into main Jun 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants