refactor: use compute-core task proof sdk#16
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the product-capture plugin to depend on the public workflow-plugin-compute-core protocol SDK instead of private workflow-compute types, while removing the locally duplicated compute HTTP client and adding a guardrail test to prevent regressions.
Changes:
- Swap protocol imports from
workflow-compute/pkg/protocoltoworkflow-plugin-compute-core/protocol. - Replace the custom
computeClientwithprotocol.Clientand update call sites accordingly. - Add a dependency-boundary test to enforce the public SDK dependency and prevent reintroducing the local client.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| module_dependency_test.go | Adds a boundary test to prevent private compute dependencies and local client duplication. |
| internal/plugin/step.go | Switches step execution to use protocol.Client and exported SDK methods. |
| internal/plugin/sign.go | Updates protocol import to compute-core SDK. |
| internal/plugin/plugin_test.go | Updates protocol import used by plugin tests. |
| internal/plugin/client.go | Removes the duplicated local compute HTTP client implementation. |
| go.mod | Replaces workflow-compute dependency with workflow-plugin-compute-core and updates indirect requirements. |
| go.sum | Updates sums to reflect the dependency swap. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
RED/GREEN Evidence
With the boundary test before the import swap:
With the fix restored: