chore: apply plugin version discipline#14
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enforces “version discipline” for the plugin manifest by keeping plugin.json at a development sentinel version in-repo, removing the now-obsolete tag-triggered sync workflow, and adding release-time validation intended to ensure the shipped manifest matches the release tag.
Changes:
- Set committed
plugin.json.versionto the0.0.0development sentinel. - Remove
.github/workflows/sync-plugin-version.yml(tag-based manifest syncing). - Add a post-build
wfctl plugin validate-contractcheck in the release workflow to validate the built/shipped manifest against the tag.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
plugin.json |
Keeps the committed manifest version at the development sentinel (0.0.0). |
.github/workflows/sync-plugin-version.yml |
Removes obsolete workflow that tried to sync manifest version on tag pushes. |
.github/workflows/release.yml |
Adds post-build validation intended to ensure the shipped manifest matches the tag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fi | ||
| "${{ runner.temp }}/wfctl-bin/wfctl" plugin verify-capabilities --binary "$BIN" . | ||
| - name: Verify shipped plugin.json carries tag (post-build) | ||
| run: '"${{ runner.temp }}/wfctl-bin/wfctl" plugin validate-contract --for-publish --tag ${{ github.ref_name }} --release-dir . .' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of GoCodeAlone/workflow#760.
Changes:
Verification: