ci: canonical registry notify (fix dead dispatch + drop manifest-overwrite)#13
Merged
Merged
Conversation
Remove direct manifest-write step (git-clone registry + jq-write plugins/openlms/manifest.json) and old notify-registry job (REGISTRY_PAT, peter-evans/repository-dispatch@v3, full github.repository payload). Add fleet-canonical notify-workflow-registry job: pinned peter-evans/repository-dispatch@28959ce (v4), repo_dispatch_token secret, bare plugin name payload {"plugin":"openlms",...}, pre-release filter (!contains ref_name '-'), needs: release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the release workflow to notify the central workflow-registry via a repository dispatch (canonical “registry-notify” pattern), removing the prior approach that directly cloned and overwrote the registry manifest.
Changes:
- Removed the step that git-cloned
GoCodeAlone/workflow-registryand directly wroteplugins/openlms/manifest.json. - Replaced the old
notify-registryjob (v3 dispatch,REGISTRY_PAT, and incorrectgithub.repositorypayload) with a newnotify-workflow-registryjob. - Added a pinned
peter-evans/repository-dispatch(v4) invocation sending the bare plugin name (openlms) and tag, guarded to skip pre-releases.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch release.yml to fleet-canonical registry-notify pattern.
Removed:
Sync manifest to registrystep: git-cloned workflow-registry and directly wroteplugins/openlms/manifest.json(fragile, bypasses registry sync logic, usedREGISTRY_PAT)notify-registryjob: usedpeter-evans/repository-dispatch@v3,REGISTRY_PATsecret, and fullgithub.repositoryas plugin name (wrong — registry expects bare nameopenlms)Added:
notify-workflow-registryjob: pinnedpeter-evans/repository-dispatch@28959ce8df70de7be546dd1250a005dd32156697(v4),repo_dispatch_tokensecret, bare-name payload{"plugin":"openlms","tag":"..."}, pre-release guard (!contains(ref_name, '-')),needs: release