chore: apply plugin version discipline#31
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Applies “version discipline” for plugin manifests by keeping the committed plugin.json at a development sentinel version while tightening CI/release validation to ensure the published artifacts are still correctly rewritten and verified.
Changes:
- Set committed
plugin.json.versionto0.0.0(development sentinel) while relying on GoReleaser rewrite hooks for real releases. - Update tests to validate download URL shape independent of the release tag, and to run all matching GoReleaser rewrite hooks.
- Extend the release workflow with runtime
verify-capabilitiesand a post-build publish validation step.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugin.json | Set committed manifest version to 0.0.0 sentinel. |
| internal/plugin_test.go | Normalize release tag in download URL assertions; execute all matching GoReleaser rewrite hooks. |
| .github/workflows/release.yml | Add runtime capability verification and post-build contract validation in the release job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of GoCodeAlone/workflow#760.
Changes:
Verification: