feat(dnsprovider): add Hover adapter (v2 PR 6 — completes cascade)#24
Merged
Conversation
Pinned to pkg/hoverclient v0.3.0 (extracted from internal/hover via workflow-plugin-hover#26 → merged 4fb779e + tag v0.3.0). Architecture: - hoverClientIface in production file (Get/List/Create/Update/Delete); *hoverclient.Client satisfies it (compile-checked). - Iface-typed .client field; tests inject stubs. - TOTP secret parsed via hoverclient.ParseBase32 — invalid base32 rejected at construction. - UpsertTXT emulates RRset replace: GetDomain → ListRecords → delete same-name TXT → CreateRecord per value (Hover API takes domain ID + per-record CRUD only). - priority dropped for non-MX/SRV (matches v1 + Hover DNSRecord has no Priority field). Tests (10): cred validation (4) + dispatch (1) + UpsertTXT foreign-record-survival (1) + GetTXT filter (1) + UpsertRecord A-priority-drop + negative-priority-reject (2) + DeleteRecord + error-redaction (2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 6 of 6 in DNS provider v2 cascade. Adds Hover adapter wrapping
pkg/hoverclient v0.3.0(extracted via workflow-plugin-hover#26 — merged today + tagged v0.3.0).Closes the v2 manifest. Completes the Hover deferral noted in PR #15 / retro #23.
Cred keys
usernamepasswordtotp_secretArchitectural notes
hoverClientIfacein production file; tests inject stubs (matches v2 cycle-4 pattern).hoverclient.ParseBase32— invalid base32 rejected at construction.UpsertTXTdoesGetDomain → ListRecords → DeleteRecord(stale) → CreateRecord(new)because Hover API takes domain ID + has no batch primitive.Test plan
GOWORK=off go vet ./...clean🤖 Generated with Claude Code