Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions internal/drivers/delegation.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,21 @@ func (d *DelegationDriver) ProviderIDFormat() interfaces.ProviderIDFormat {
return interfaces.IDFormatDomainName
}

// AdoptionRef lets wfctl adopt an already-delegated domain before creating
// registrar state. Read uses public NS first, so an already-correct delegation
// can plan as no-op without requiring Hover authentication.
func (d *DelegationDriver) AdoptionRef(spec interfaces.ResourceSpec) (interfaces.ResourceRef, bool, error) {
s, err := parseDelegationSpec(spec)
if err != nil {
return interfaces.ResourceRef{}, false, err
}
return interfaces.ResourceRef{
Name: spec.Name,
Type: "infra.dns_delegation",
ProviderID: s.domain,
}, true, nil
}

// dnsDelegationSpec is the parsed config view.
type dnsDelegationSpec struct {
domain string
Expand Down
21 changes: 21 additions & 0 deletions internal/drivers/delegation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,27 @@ func TestDelegationDriver_Read_UsesPublicNSBeforeHoverLogin(t *testing.T) {
}
}

func TestDelegationDriver_AdoptionRef_UsesSpecDomain(t *testing.T) {
d := NewDelegationDriverWithClient(&fakeDelegationClient{})
ref, ok, err := d.AdoptionRef(interfaces.ResourceSpec{
Name: "delegation",
Type: "infra.dns_delegation",
Config: map[string]any{
"domain": "example.com",
"nameservers": []any{"ns1.example.com"},
},
})
if err != nil {
t.Fatalf("AdoptionRef: %v", err)
}
if !ok {
t.Fatal("expected adoption ref")
}
if ref.Name != "delegation" || ref.Type != "infra.dns_delegation" || ref.ProviderID != "example.com" {
t.Fatalf("unexpected ref: %+v", ref)
}
}

func TestDelegationDriver_Read_PropagatesError(t *testing.T) {
fc := &fakeDelegationClient{getErr: errors.New("API down")}
d := NewDelegationDriverWithClient(fc)
Expand Down