Skip to content

feat: support product capture workloads#2

Merged
intel352 merged 1 commit into
mainfrom
feat/product-capture-provider
May 21, 2026
Merged

feat: support product capture workloads#2
intel352 merged 1 commit into
mainfrom
feat/product-capture-provider

Conversation

@intel352
Copy link
Copy Markdown
Contributor

Summary

  • add typed product-capture dispatch support through step.compute_dispatch and step.compute_map strict decoding
  • add wfctl compute submit product-capture for targeted testing and smoke workflows
  • update workflow-compute dependency to the product-capture protocol/provider commit from GoCodeAlone/workflow-compute#111

Validation

  • GOWORK=off go test ./...

Copilot AI review requested due to automatic review settings May 20, 2026 23:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for submitting/dispatching the new product-capture compute workload type, including CLI ergonomics and regression tests, and updates the workflow-compute dependency to a protocol/provider revision that includes product-capture support.

Changes:

  • Added dispatch step tests covering acceptance of product-capture workloads and strict rejection of unknown nested product_capture fields.
  • Added wfctl compute submit product-capture subcommand to construct/validate and submit product-capture tasks.
  • Updated github.com/GoCodeAlone/workflow-compute dependency (and indirect pgx) to pick up the product-capture protocol/provider updates.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/steps_test.go Adds coverage for dispatch step handling of product-capture workload config and strict decoding behavior.
internal/cli.go Implements compute submit product-capture command and wires it into wfctl compute submit.
internal/cli_test.go Adds CLI test ensuring product-capture submit emits a compact receipt and does not leak request details.
go.mod Bumps workflow-compute dependency (and pgx indirect) to versions containing product-capture support.
go.sum Updates checksums consistent with the module version bumps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@intel352 intel352 force-pushed the feat/product-capture-provider branch 2 times, most recently from 0cc97ec to 67b6127 Compare May 21, 2026 00:04
@intel352 intel352 force-pushed the feat/product-capture-provider branch from 67b6127 to 48b68e3 Compare May 21, 2026 00:09
@intel352 intel352 merged commit aafde9c into main May 21, 2026
4 checks passed
@intel352 intel352 deleted the feat/product-capture-provider branch May 21, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants