Align provider catalog with workflow-compute#1
Merged
Conversation
01b1b14 to
c9c1330
Compare
There was a problem hiding this comment.
Pull request overview
Aligns this plugin’s provider catalog shape and runtime registration with workflow-compute’s typed protocol.ProviderContract, and adds CI coverage to detect catalog drift against workflow-compute main.
Changes:
- Adds new module type
compute.provider_catalogbacked byprotocol.ProviderContract+ validation and tests. - Exposes the new module in runtime schemas and
plugin.jsoncapabilities. - Adds a CI “alignment” job step and a helper script that checks out
GoCodeAlone/workflow-computeand runs catalog-focused tests with a localgo.modreplace.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SPEC.md | Documents the new provider-catalog alignment constraint and CI drift gate. |
| scripts/check-workflow-compute-alignment.sh | Adds a helper script to run alignment tests against a local workflow-compute checkout. |
| README.md | Documents that provider catalog uses core ProviderContract records. |
| plugin.json | Registers compute.provider_catalog in manifest capabilities and updates description text. |
| internal/plugin.go | Registers/constructs the new module type and exposes its schema. |
| internal/module.go | Implements compute.provider_catalog module + adds provider_catalog_ref to pool config/schema. |
| internal/module_test.go | Adds tests for provider catalog typing/validation and manifest moduleTypes alignment. |
| go.mod | Bumps workflow-compute dependency version (and indirect pgx bump). |
| go.sum | Records new dependency sums. |
| .github/workflows/build.yml | Adds checkout of workflow-compute and runs the alignment script in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ConfigFields: []sdk.ConfigField{ | ||
| {Name: "provider_ref", Type: "string", Description: "Name of the compute.provider module.", Required: true}, | ||
| {Name: "provider_ref", Type: "string", Description: "Name of the compute.provider control-plane module.", Required: true}, | ||
| {Name: "provider_catalog_ref", Type: "string", Description: "Optional name of the compute.provider_catalog module that constrains provider policy."}, |
Comment on lines
2
to
5
| "name": "workflow-plugin-compute", | ||
| "version": "0.1.0", | ||
| "description": "Workflow adapter for workflow-compute dispatch, wait, map, provider, and pool integration", | ||
| "description": "Workflow adapter for workflow-compute dispatch, wait, map, provider, pool, and provider catalog integration", | ||
| "author": "GoCodeAlone", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute.provider_catalogwith workflow-compute's typedprotocol.ProviderContractplugin.jsonGoCodeAlone/workflow-computeand runs catalog tests with a local module replaceDrift Found
The plugin had started carrying grouped provider details (
executor_providers,dependency_providers,verification_providers,reward_providers,network_providers) while workflow-compute now defines provider catalog entries asProviderContractrecords. The module was also absent from plugin runtime registration andplugin.json.Verification
GOWORK=off GOPRIVATE=github.com/GoCodeAlone/* GONOSUMDB=github.com/GoCodeAlone/* go test ./...GOPRIVATE=github.com/GoCodeAlone/* GONOSUMDB=github.com/GoCodeAlone/* scripts/check-workflow-compute-alignment.sh /Users/jon/workspace/workflow-compute-salvage-auditwfctl validate workflow.yamlGOWORK=off wfctl build --config workflow.yaml --no-push --tag localgit diff --checkTDD Proof
With fix missing:
With fix restored: