Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions protocol/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -1920,6 +1920,43 @@ func (e ProviderConformanceEvidence) Validate() error {
return errors.Join(errs...)
}

func (c *ProviderContract) ApplyProviderConformanceEvidence(evidence ProviderConformanceEvidence) error {
if c == nil {
return errors.New("provider contract is nil")
}
if err := evidence.Validate(); err != nil {
return err
}
if evidence.PluginID != c.PluginID ||
evidence.ProviderID != c.ProviderID ||
evidence.ContractID != c.ContractID ||
evidence.Version != c.Version {
return fmt.Errorf("provider conformance evidence %q does not match provider contract tuple", evidence.ID)
}
for i := range c.RuntimeContract.Profiles {
if c.RuntimeContract.Profiles[i].ID != evidence.RuntimeProfileID {
continue
}
c.RuntimeContract.Profiles[i].UpstreamClientConformance = UpstreamClientConformanceRealClient
c.RuntimeContract.Profiles[i].UpstreamClientEvidenceRef = evidence.EvidenceRef
c.RuntimeContract.Profiles[i].UpstreamClientEvidenceDigest = evidence.EvidenceDigest
if !containsString(c.RuntimeContract.Profiles[i].ConformanceProfiles, evidence.ConformanceProfile) {
c.RuntimeContract.Profiles[i].ConformanceProfiles = append(c.RuntimeContract.Profiles[i].ConformanceProfiles, evidence.ConformanceProfile)
}
return nil
}
return fmt.Errorf("provider conformance evidence %q runtime profile %q does not match provider contract", evidence.ID, evidence.RuntimeProfileID)
}

func containsString(values []string, target string) bool {
for _, value := range values {
if value == target {
return true
}
}
return false
}

type ProviderUpstreamClientRequirement struct {
ProtocolVersion string `json:"protocol_version"`
PluginID string `json:"plugin_id"`
Expand Down
60 changes: 60 additions & 0 deletions protocol/types_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package protocol_test

import (
"encoding/json"
"slices"
"strings"
"testing"
"time"
Expand Down Expand Up @@ -728,6 +729,65 @@ func TestProviderConformanceEvidenceRequiresArtifactDigestAndObservation(t *test
}
}

func TestProviderContractAppliesProviderConformanceEvidence(t *testing.T) {
contract := validBatchProviderContract()
profile := contract.RuntimeContract.Profiles[0]
evidence := protocol.ProviderConformanceEvidence{
ProtocolVersion: protocol.Version,
ID: "example-real-client-evidence",
PluginID: contract.PluginID,
ProviderID: contract.ProviderID,
ContractID: contract.ContractID,
Version: contract.Version,
RuntimeProfileID: profile.ID,
ConformanceProfile: "upstream-client-v1",
UpstreamClientName: "example-client",
UpstreamClientVersion: "1.2.3",
EvidenceRef: "artifact://providers/example/evidence/upstream-client-v1",
EvidenceDigest: protocol.CanonicalHash("evidence"),
ObservedAt: time.Now().UTC(),
}

if err := contract.ApplyProviderConformanceEvidence(evidence); err != nil {
t.Fatalf("apply evidence: %v", err)
}
got := contract.RuntimeContract.Profiles[0]
if got.UpstreamClientConformance != protocol.UpstreamClientConformanceRealClient ||
got.UpstreamClientEvidenceRef != evidence.EvidenceRef ||
got.UpstreamClientEvidenceDigest != evidence.EvidenceDigest {
t.Fatalf("runtime profile evidence was not applied: %+v", got)
}
if !slices.Contains(got.ConformanceProfiles, evidence.ConformanceProfile) {
t.Fatalf("runtime profile missing conformance profile %q: %+v", evidence.ConformanceProfile, got.ConformanceProfiles)
}
if err := contract.ApplyProviderConformanceEvidence(evidence); err != nil {
t.Fatalf("reapply evidence: %v", err)
}
if got := contract.RuntimeContract.Profiles[0].ConformanceProfiles; countString(got, evidence.ConformanceProfile) != 1 {
t.Fatalf("runtime profile duplicated conformance profile %q: %+v", evidence.ConformanceProfile, got)
}

evidence.PluginID = "workflow-plugin-other"
if err := contract.ApplyProviderConformanceEvidence(evidence); err == nil || !strings.Contains(err.Error(), "does not match provider contract tuple") {
t.Fatalf("expected tuple mismatch error, got %v", err)
}
evidence.PluginID = contract.PluginID
evidence.RuntimeProfileID = "missing-runtime"
if err := contract.ApplyProviderConformanceEvidence(evidence); err == nil || !strings.Contains(err.Error(), "runtime profile") {
t.Fatalf("expected runtime profile mismatch error, got %v", err)
}
}

func countString(values []string, target string) int {
count := 0
for _, value := range values {
if value == target {
count++
}
}
return count
}

func validBatchProviderContract() protocol.ProviderContract {
return protocol.ProviderContract{
ProtocolVersion: protocol.Version,
Expand Down
Loading