chore: adopt workflow v0.74.5 CI validation#24
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the plugin to align with github.com/GoCodeAlone/workflow v0.74.5 behavior and strengthens CI generation by validating rendered artifacts before writing them to disk, while also refreshing GitHub Actions workflows and fixing the default runner.
Changes:
- Bump
github.com/GoCodeAlone/workflowdependency tov0.74.5(plus associated indirect updates). - Validate rendered CI artifacts via
cigen.ValidateRenderedFilesbefore writing plugin output files. - Update defaults/docs/CI workflows: default runner to
ubuntu-latest, workflow actions to newer majors, andwfctlused in release validation tov0.74.5.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/generator.go | Switch default runner to ubuntu-latest and validate rendered artifacts before writing files. |
| internal/generator_test.go | Add a test asserting rendered artifact validation failures are surfaced as typed output errors. |
| go.mod | Bump workflow dependency to v0.74.5 and accept new indirect dependencies. |
| go.sum | Update checksums to match the dependency graph after the workflow bump. |
| examples/minimal/config.yaml | Update example commentary to reflect all platforms being config-derived via cigen. |
| .github/workflows/release.yml | Update checkout/setup-go majors and move release contract validation to wfctl v0.74.5. |
| .github/workflows/ci.yml | Update checkout/setup-go majors in CI workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/GoCodeAlone/workflowtov0.74.5.cigen.ValidateRenderedFileshelper before writing plugin output.self-hosted, Linux, X64toubuntu-latest, while preserving explicit runner overrides.actions/checkout@v6,actions/setup-go@v6.wfctl v0.63.2workaround to the fixedwfctl v0.74.5release.Verification
GOWORK=off go test ./internal -run 'TestExecuteCIGenerate' -count=1GOWORK=off go test ./... -count=1git diff --checkDepends on GoCodeAlone/workflow#863 and GoCodeAlone/workflow#862, released in workflow
v0.74.5.