feat: add ACI IaCProviderRunner#36
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for the optional IaCProviderRunner contract to the Azure plugin by running portable JobSpec jobs as one-off Azure Container Instances (ACI) container groups, and bumps the required workflow engine version to support the new typed service.
Changes:
- Implement
IaCProviderRunnerinAzureProvider(run job, map status, fetch logs) backed by ACI container groups. - Expose the new runner service via the typed gRPC server and ensure it auto-registers with the SDK.
- Update plugin manifests and dependencies to require workflow
v0.73.0(and related indirect bumps).
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| plugin.json | Bumps minEngineVersion and advertises IaCProviderRunner in iacServices. |
| cmd/workflow-plugin-azure/plugin.json | Keeps embedded manifest in sync (engine version + runner service). |
| internal/provider.go | Initializes ACI clients and wires runnerClient into AzureProvider. |
| internal/runner.go | Core ACI job execution, status mapping, and log retrieval implementation. |
| internal/runner_server.go | Typed gRPC service methods + PB↔︎interfaces conversions for runner RPCs. |
| internal/runner_test.go | Unit tests for container group creation, status/log mapping, and service registration. |
| internal/iacserver.go | Adds runner service embed/guard so SDK auto-registration succeeds. |
| internal/iacserver_mapper_test.go | Updates manifest test expectation for minEngineVersion. |
| go.mod | Bumps workflow dependency to v0.73.0 (and indirect deps). |
| go.sum | Updates sums for the dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the optional IaCProviderRunner service for Azure using Container Instances.\n\n- registers provider-owned runner service in the typed IaC server\n- launches one-off ACI container groups from portable JobSpec image/command/env\n- maps ACI container state to provider-neutral JobState\n- streams ACI container logs through JobLogs\n- advertises workflow.plugin.external.iac.IaCProviderRunner and requires workflow v0.73.0\n\nVerification:\n- GOWORK=off go test ./...\n\nRefs GoCodeAlone/workflow#840