Skip to content

feat: add ownership tagging#35

Merged
intel352 merged 2 commits into
mainfrom
issue-779-ownership
Jun 2, 2026
Merged

feat: add ownership tagging#35
intel352 merged 2 commits into
mainfrom
issue-779-ownership

Conversation

@intel352
Copy link
Copy Markdown
Contributor

@intel352 intel352 commented Jun 2, 2026

Summary

  • Add IaCProviderOwnership support using the Azure ARM workflow-owner tag
  • Wire ownership through the typed IaC gRPC server and root/embedded manifests
  • Bump workflow dependency and minEngineVersion for the ownership contract

Verification

  • GOWORK=off go test ./internal -run 'Test.*Owner|TestOwnershipProviderCompileGuard|TestAzureIaCServer_RegistersOwnership|TestPluginManifestAdvertisesOwnership|TestIaCServer_CompileTimeGuards' -count=1
  • GOWORK=off go test ./... -count=1
  • GOWORK=off go vet ./...
  • git diff --check

Refs GoCodeAlone/workflow#779

Copilot AI review requested due to automatic review settings June 2, 2026 04:01
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the new typed IaC ownership contract to the Azure workflow plugin by mapping ownership to the Azure ARM workflow-owner tag, and updates manifests/dependencies to the engine version that supports this service.

Changes:

  • Implemented IaCProviderOwnership (Get/Set/List) in the typed gRPC IaC server and in AzureProvider, backed by Azure ARM tags and resource listing.
  • Updated both plugin manifests to advertise IaCProviderOwnership and raised minEngineVersion to 0.69.1.
  • Bumped github.com/GoCodeAlone/workflow dependency and added Azure armresources dependency; added/extended internal tests for registration and manifest conformance.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/ownership.go Implements ownership operations using ARM tags/resources clients and maps ARM resource types to workflow resource types.
internal/provider.go Wires Azure ARM TagsClient/Resources Client creation into provider initialization and cleans them up on close.
internal/iacserver.go Exposes ownership RPCs via typed IaC gRPC server and embeds the unimplemented ownership server for forward-compat.
internal/ownership_test.go Adds unit tests for Set/Get/List ownership behavior using fakes.
internal/region_lister_test.go Adds service registration + manifest advertisement tests for ownership (and checks both manifests).
internal/iacserver_test.go Extends compile-time guard test to include IaCProviderOwnershipServer.
internal/iacserver_mapper_test.go Updates minEngineVersion expectation to 0.69.1.
plugin.json Raises minEngineVersion and advertises the ownership IaC service.
cmd/workflow-plugin-azure/plugin.json Mirrors root manifest changes (min engine + ownership service).
go.mod / go.sum Bumps workflow dependency and adds Azure armresources module (plus transitive sum updates).
CHANGELOG.md Documents the new ownership support and engine version requirement.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/ownership.go
@intel352 intel352 merged commit 42e5e50 into main Jun 2, 2026
5 checks passed
@intel352 intel352 deleted the issue-779-ownership branch June 2, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants