feat: add ownership tagging#35
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the new typed IaC ownership contract to the Azure workflow plugin by mapping ownership to the Azure ARM workflow-owner tag, and updates manifests/dependencies to the engine version that supports this service.
Changes:
- Implemented
IaCProviderOwnership(Get/Set/List) in the typed gRPC IaC server and inAzureProvider, backed by Azure ARM tags and resource listing. - Updated both plugin manifests to advertise
IaCProviderOwnershipand raisedminEngineVersionto0.69.1. - Bumped
github.com/GoCodeAlone/workflowdependency and added Azurearmresourcesdependency; added/extended internal tests for registration and manifest conformance.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
internal/ownership.go |
Implements ownership operations using ARM tags/resources clients and maps ARM resource types to workflow resource types. |
internal/provider.go |
Wires Azure ARM TagsClient/Resources Client creation into provider initialization and cleans them up on close. |
internal/iacserver.go |
Exposes ownership RPCs via typed IaC gRPC server and embeds the unimplemented ownership server for forward-compat. |
internal/ownership_test.go |
Adds unit tests for Set/Get/List ownership behavior using fakes. |
internal/region_lister_test.go |
Adds service registration + manifest advertisement tests for ownership (and checks both manifests). |
internal/iacserver_test.go |
Extends compile-time guard test to include IaCProviderOwnershipServer. |
internal/iacserver_mapper_test.go |
Updates minEngineVersion expectation to 0.69.1. |
plugin.json |
Raises minEngineVersion and advertises the ownership IaC service. |
cmd/workflow-plugin-azure/plugin.json |
Mirrors root manifest changes (min engine + ownership service). |
go.mod / go.sum |
Bumps workflow dependency and adds Azure armresources module (plus transitive sum updates). |
CHANGELOG.md |
Documents the new ownership support and engine version requirement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Refs GoCodeAlone/workflow#779