Skip to content

feat: expose provider region lister#34

Merged
intel352 merged 4 commits into
mainfrom
feat/813-region-lister
Jun 1, 2026
Merged

feat: expose provider region lister#34
intel352 merged 4 commits into
mainfrom
feat/813-region-lister

Conversation

@intel352
Copy link
Copy Markdown
Contributor

@intel352 intel352 commented Jun 1, 2026

Refs GoCodeAlone/workflow#813.

Adds the optional IaCProviderRegionLister typed service so workflow admin surfaces can use provider-sourced Azure regions instead of the local fallback catalog.

Verification:

  • GOWORK=off go test ./...

Copilot AI review requested due to automatic review settings June 1, 2026 16:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the optional typed gRPC service IaCProviderRegionLister so the Workflow host/admin UI can ask the Azure IaC plugin for a region list instead of relying on a host-side fallback catalog.

Changes:

  • Advertises workflow.plugin.external.iac.IaCProviderRegionLister in the plugin manifest.
  • Implements ListRegions on azureIaCServer and adds coverage to ensure the service is registered and advertised.
  • Updates github.com/GoCodeAlone/workflow (and related indirect deps) to a version that includes the new typed service.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
plugin.json Advertises the new typed IaC region lister service in iacServices.
internal/region_lister.go Adds ListRegions implementation returning a region list.
internal/region_lister_test.go Adds tests for region listing, service registration, and manifest advertising.
internal/iacserver.go Adds RegionLister unimplemented embed and compile-time interface guard.
go.mod Bumps workflow dependency to a version that includes RegionLister.
go.sum Updates sums for the dependency upgrades.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/region_lister.go Outdated
Comment thread plugin.json
Comment thread internal/region_lister_test.go
Copilot AI review requested due to automatic review settings June 1, 2026 16:43
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Comment thread internal/region_lister.go
@intel352 intel352 merged commit 07ffd8d into main Jun 1, 2026
5 checks passed
@intel352 intel352 deleted the feat/813-region-lister branch June 1, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants