feat: expose provider region lister#34
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for the optional typed gRPC service IaCProviderRegionLister so the Workflow host/admin UI can ask the Azure IaC plugin for a region list instead of relying on a host-side fallback catalog.
Changes:
- Advertises
workflow.plugin.external.iac.IaCProviderRegionListerin the plugin manifest. - Implements
ListRegionsonazureIaCServerand adds coverage to ensure the service is registered and advertised. - Updates
github.com/GoCodeAlone/workflow(and related indirect deps) to a version that includes the new typed service.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| plugin.json | Advertises the new typed IaC region lister service in iacServices. |
| internal/region_lister.go | Adds ListRegions implementation returning a region list. |
| internal/region_lister_test.go | Adds tests for region listing, service registration, and manifest advertising. |
| internal/iacserver.go | Adds RegionLister unimplemented embed and compile-time interface guard. |
| go.mod | Bumps workflow dependency to a version that includes RegionLister. |
| go.sum | Updates sums for the dependency upgrades. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs GoCodeAlone/workflow#813.
Adds the optional
IaCProviderRegionListertyped service so workflow admin surfaces can use provider-sourced Azure regions instead of the local fallback catalog.Verification:
GOWORK=off go test ./...