ci: canonical registry notify (fix dead dispatch + drop manifest-overwrite)#33
Merged
Conversation
Replaces the old notify-registry dispatch step (REGISTRY_PAT, full github.repository as plugin name, peter-evans/repository-dispatch@v3, guarded by continue-on-error) with a dedicated notify-workflow-registry job using the fleet-canonical shape: - token: secrets.repo_dispatch_token - client-payload plugin field: bare name "azure" (not github.repository) - pinned SHA peter-evans/repository-dispatch@28959ce... # v4 - if-guard: no deleted events, no pre-release tags, correct repo The old REGISTRY_PAT reference is removed entirely; the publish-GitHub- release github-script step is retained in its existing notify-registry job unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the release workflow to replace the previously broken workflow-registry notification (which relied on a step-level env for its if guard) with a dedicated, pinned repository-dispatch job intended to follow the fleet “canonical” registry notification pattern.
Changes:
- Removes the old
peter-evans/repository-dispatch@v3step that referencedREGISTRY_PATand sent the fullgithub.repositoryas the plugin identifier. - Adds a new
notify-workflow-registryjob that dispatchesplugin-releasetoGoCodeAlone/workflow-registryusing a pinned SHA and the bare plugin name ("azure"). - Keeps the existing
github-scriptstep that flips GoReleaser draft releases to non-draft (but see comments aboutworkflow_dispatchbehavior).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+114
to
+126
| if: >- | ||
| !github.event.deleted | ||
| && !contains(github.ref_name, '-') | ||
| && github.repository == 'GoCodeAlone/workflow-plugin-azure' | ||
| steps: | ||
| - name: Trigger registry manifest sync | ||
| uses: peter-evans/repository-dispatch@28959ce8df70de7be546dd1250a005dd32156697 # v4 | ||
| with: | ||
| token: ${{ secrets.repo_dispatch_token }} | ||
| repository: GoCodeAlone/workflow-registry | ||
| event-type: plugin-release | ||
| client-payload: |- | ||
| {"plugin": "azure", "tag": "${{ github.ref_name }}"} |
Comment on lines
80
to
82
| @@ -82,18 +82,6 @@ jobs: | |||
| needs: [release] | |||
Comment on lines
85
to
87
| - name: Publish GitHub release | ||
| uses: actions/github-script@v7 | ||
| with: |
The job now only flips the release draft->non-draft; rename it for clarity and chain notify-workflow-registry after it (needs: publish-release), matching the rest of the fleet. No functional change to publishing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the broken
notify-registrydispatch step with the fleet-canonicalnotify-workflow-registryjob.What changed:
REGISTRY_PATreference and oldpeter-evans/repository-dispatch@v3step with fullgithub.repositoryplugin namenotify-workflow-registryjob: pinned SHA@28959ce(v4),repo_dispatch_token, bare plugin name"azure", and canonical if-guard (no deleted, no pre-release, correct repo)notify-registryjob'sgithub-scriptstep that flips GoReleaser draft releases to non-draftCo-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com