feat: map observability requirements for azure#31
Merged
Conversation
08121af to
48663de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IaCProviderRequirementMapperservice for Azure observability requirementsinfra.container_serviceOTel Collector module for Azure Container Apps intent, covering OTel, Datadog, Prometheus, Loki, and Grafana backendsplugin.json, bumps Workflow minimum to0.64.3, adds release download entries, and moves GoReleaser publishing to.release/plugin.jsonTDD / Regression Proof
With mapper registration and ACI command wiring reverted:
With the implementation restored:
Port bounds regression proof:
$ GOWORK=off go test ./internal/driver -run TestACIDriver_Create_CollectorConfig -count=1 FAIL: container ports = [4317 4318 9464 70000], want [4317 4318 9464]After restoring the bound:
$ GOWORK=off go test ./internal/driver -run TestACIDriver_Create_CollectorConfig -count=1 ok github.com/GoCodeAlone/workflow-plugin-azure/internal/driverVerification