feat: add AWS ownership tagging#37
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds AWS ownership tagging to the plugin by implementing the IaCProviderOwnership contract via the Resource Groups Tagging API. The provider tags ARN-backed resources with the workflow-owner key and exposes GetOwner/SetOwner/ListOwners through the gRPC IaC server. The workflow dependency and minEngineVersion are bumped to 0.69.x for the new contract, and root/embedded plugin.json manifests are aligned (with a parity test).
Changes:
- New
provider/ownership.goimplementsOwnershipProviderwith ARN→ResourceRef mapping and a tagged-resource client interface; covered byprovider/ownership_test.gowith a fake client. internal/iacserver.goregisters the ownership server and exposesGetOwner/SetOwner/ListOwnersRPCs; manifests in bothplugin.jsonfiles advertiseIaCProviderOwnership(and embedded manifest now also includes the previously missingIaCProviderRegionLister), with mapper/host conformance tests updated for parity and version.- Dependency bumps:
workflow v0.69.7,aws-sdk-go-v2 v1.41.9, newservice/resourcegroupstaggingapi v1.32.2,smithy-go v1.26.0;CHANGELOG.mdupdated.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| provider/ownership.go | New OwnershipProvider implementation with ARN parsing helpers |
| provider/ownership_test.go | Unit tests with a fake tagging client |
| provider/provider.go | Wires the resourcegroupstaggingapi client into the provider |
| internal/iacserver.go | Registers and serves the IaCProviderOwnership RPCs |
| internal/iacserver_test.go | Adds compile-time guard for ownership server |
| internal/iacserver_mapper_test.go | Updates manifest test to require new service + version |
| internal/host_conformance_test.go | New test ensuring root/embedded manifests match |
| plugin.json | Bumps minEngineVersion and advertises ownership service |
| cmd/workflow-plugin-aws/plugin.json | Same advertisement, plus adds RegionLister for parity |
| go.mod / go.sum | Dependency bumps (workflow, aws-sdk-go-v2, tagging API, smithy-go) |
| CHANGELOG.md | Documents the new ownership feature and version bump |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IaCProviderOwnershipsupport using theworkflow-ownertag keyiacServicesmanifests in parityVerification
Refs GoCodeAlone/workflow#779