Skip to content

feat: expose provider region lister#36

Merged
intel352 merged 4 commits into
mainfrom
feat/813-region-lister
Jun 1, 2026
Merged

feat: expose provider region lister#36
intel352 merged 4 commits into
mainfrom
feat/813-region-lister

Conversation

@intel352
Copy link
Copy Markdown
Contributor

@intel352 intel352 commented Jun 1, 2026

Refs GoCodeAlone/workflow#813.

Adds the optional IaCProviderRegionLister typed service so workflow admin surfaces can use provider-sourced AWS regions instead of the local fallback catalog.

Verification:

  • GOWORK=off go test ./...

Copilot AI review requested due to automatic review settings June 1, 2026 16:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the new optional typed IaC service IaCProviderRegionLister so Workflow admin surfaces can request an AWS region list from the plugin rather than relying on a host-side fallback catalog.

Changes:

  • Advertises the IaCProviderRegionLister service in plugin.json.
  • Implements ListRegions on the typed IaC server and adds tests verifying behavior + registration + manifest advertising.
  • Bumps github.com/GoCodeAlone/workflow (and related indirect deps) to a version that includes the new typed service definitions.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
plugin.json Adds the new typed service to the plugin’s advertised IaC services list.
internal/region_lister.go Implements the IaCProviderRegionLister gRPC method (ListRegions).
internal/region_lister_test.go Adds unit tests for region listing, service registration, and manifest parity.
internal/iacserver.go Updates the server struct/interface assertions to include IaCProviderRegionLister.
go.mod Bumps workflow dependency (and indirect deps) to a version containing the new service.
go.sum Updates checksums corresponding to the dependency bumps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/region_lister.go Outdated
Comment thread internal/region_lister.go Outdated
Comment thread internal/region_lister_test.go
Comment thread internal/region_lister.go Outdated
Comment thread internal/region_lister.go Outdated
Comment thread internal/region_lister_test.go
Comment thread internal/region_lister.go Outdated
Comment thread internal/region_lister.go Outdated
Comment thread internal/region_lister_test.go
Copilot AI review requested due to automatic review settings June 1, 2026 16:43
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

cmd/workflow-plugin-aws/plugin.json:13

  • cmd/workflow-plugin-aws/plugin.json is the manifest embedded into the plugin binary (see cmd/workflow-plugin-aws/main.go). It currently does not list IaCProviderRegionLister under iacServices, so the host may not discover the new typed service even though it is implemented and advertised in the repo-root plugin.json.
  "minEngineVersion": "0.68.2",
  "iacServices": [
    "workflow.plugin.external.iac.IaCProviderRequired",
    "workflow.plugin.external.iac.IaCProviderEnumerator",
    "workflow.plugin.external.iac.IaCProviderDriftDetector",

Comment thread internal/region_lister.go
@intel352 intel352 merged commit aa30018 into main Jun 1, 2026
5 checks passed
@intel352 intel352 deleted the feat/813-region-lister branch June 1, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants