feat: expose provider region lister#36
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for the new optional typed IaC service IaCProviderRegionLister so Workflow admin surfaces can request an AWS region list from the plugin rather than relying on a host-side fallback catalog.
Changes:
- Advertises the
IaCProviderRegionListerservice inplugin.json. - Implements
ListRegionson the typed IaC server and adds tests verifying behavior + registration + manifest advertising. - Bumps
github.com/GoCodeAlone/workflow(and related indirect deps) to a version that includes the new typed service definitions.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| plugin.json | Adds the new typed service to the plugin’s advertised IaC services list. |
| internal/region_lister.go | Implements the IaCProviderRegionLister gRPC method (ListRegions). |
| internal/region_lister_test.go | Adds unit tests for region listing, service registration, and manifest parity. |
| internal/iacserver.go | Updates the server struct/interface assertions to include IaCProviderRegionLister. |
| go.mod | Bumps workflow dependency (and indirect deps) to a version containing the new service. |
| go.sum | Updates checksums corresponding to the dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
cmd/workflow-plugin-aws/plugin.json:13
- cmd/workflow-plugin-aws/plugin.json is the manifest embedded into the plugin binary (see cmd/workflow-plugin-aws/main.go). It currently does not list IaCProviderRegionLister under iacServices, so the host may not discover the new typed service even though it is implemented and advertised in the repo-root plugin.json.
"minEngineVersion": "0.68.2",
"iacServices": [
"workflow.plugin.external.iac.IaCProviderRequired",
"workflow.plugin.external.iac.IaCProviderEnumerator",
"workflow.plugin.external.iac.IaCProviderDriftDetector",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs GoCodeAlone/workflow#813.
Adds the optional
IaCProviderRegionListertyped service so workflow admin surfaces can use provider-sourced AWS regions instead of the local fallback catalog.Verification:
GOWORK=off go test ./...