feat(v2): ComputePlanVersion=v2 + workflow v0.54.0 + minEngine 0.54.0#16
Merged
Conversation
…e 0.54.0 Phase 2 cascade per workflow#640 + ADR 0040: opt this plugin into the v2 action lifecycle contract. wfctl v0.54.0+ expects plugins declaring ComputePlanVersion="v2" to populate ApplyResult.Actions with one ActionResult per planned action (enforced by the engine-side length-validation assert in iac/wfctlhelpers/apply.go) and to never emit ACTION_STATUS_UNSPECIFIED or unknown wire tags. Per ADR 0024 + ADR 0040, there is no compat shim: plugins NOT declaring v2 are permanently incompatible with workflow v0.54.0+. Surface changes (4 files; minimal): - go.mod: pin workflow v0.53.0 → v0.54.0; go.sum refreshed via tidy - plugin.json: minEngineVersion 0.53.0 → 0.54.0 - internal/iacserver.go: awsIaCServer.Capabilities return-struct literal adds ComputePlanVersion: "v2" (no signature, receiver, or parameter change) Rollback: cut v1.2.1 re-pinning workflow → v0.53.0 + dropping ComputePlanVersion="v2"; per ADR 0040, v1.2.x can only target workflow v0.54.0+, so a true rollback requires v1.2.1 with the v0.53.x pin restored. Verification: - go mod tidy clean - GOWORK=off go build ./... clean - GOWORK=off go test ./... -race -count=1 → all PASS Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Opts the AWS workflow plugin into the v2 action lifecycle contract by bumping the workflow dependency to v0.54.0, raising minEngineVersion, and adding ComputePlanVersion: "v2" to the Capabilities response.
Changes:
- Bump
github.com/GoCodeAlone/workflowto v0.54.0 and prune indirect deps viago mod tidy. - Raise
minEngineVersionto 0.54.0 inplugin.json. - Set
ComputePlanVersion: "v2"in theawsIaCServer.Capabilitiesresponse.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Upgrade workflow to v0.54.0; drop now-unused indirect deps. |
| go.sum | Refreshed checksums to match the new dependency graph. |
| plugin.json | Raise minimum engine version to 0.54.0. |
| internal/iacserver.go | Declare ComputePlanVersion: "v2" in capabilities response. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 cascade per workflow#640 + ADR 0040. Opts this plugin into the v2 action lifecycle contract: declares
ComputePlanVersion="v2"inCapabilitiesResponseso wfctl v0.54.0+ knows to expect populatedApplyResult.Actions(oneActionResultper planned action, noACTION_STATUS_UNSPECIFIED, no unknown tags).Per ADR 0024 + ADR 0040, plugins NOT declaring v2 are permanently incompatible with workflow v0.54.0+; there is no compat shim. This PR makes the AWS plugin v0.54.0-compatible.
Surface changes (minimal — 4 files)
go.mod: workflow v0.53.0 → v0.54.0go.sum: refreshed viago mod tidyplugin.json:minEngineVersion0.53.0 → 0.54.0internal/iacserver.go:awsIaCServer.Capabilitiesreturn-struct literal addsComputePlanVersion: "v2"(no signature/receiver/parameter change)Rollback (if downstream breaks)
Cut
v1.2.1re-pinningworkflow → v0.53.0and droppingComputePlanVersion="v2". Per ADR 0040,v1.2.xtags can only target workflow v0.54.0+, so a true rollback to v0.53.x users requires the v1.2.1 with the v0.53.x pin restored.Test plan
go mod tidycleanGOWORK=off go build ./...cleanGOWORK=off go test ./... -race -count=1→ all PASSCoordinated cascade
This is PR 2 of 5 in the v2-phase2 plugin cascade (PR 1 was the workflow engine PR #694, merged at v0.54.0). Sibling PRs: gcp, azure, digitalocean. All five plugins must declare v2 to maintain ecosystem compatibility with workflow v0.54.0+.
🤖 Generated with Claude Code