Cloud-SDK extraction B/C/D — PR 3: serve s3 IaCStateBackend#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/statebackend/s3.go) and serves it as thes3backend viapb.IaCStateBackendServer+ theConfigureRPC.DO_SPACES_*credential env-var fallbacks and the<region>.digitaloceanspaces.comendpoint derivation — an awss3backend uses an explicitendpointconfig (S3-compatible) or the SDK's standard AWS S3 endpoint resolution, never a DO URL.Configure(the azure precedent); workflow pinned to PR 1 merge522748f3.Plan PR 3 (cross-repo) of the cloud-SDK-extraction B/C/D plan. PR 4 (storage.s3 + step.s3_upload + credentials) follows on the same repo.
Test plan
go build ./...,go test ./...green incl. host conformanceConfigurebuilds store; 6 state RPCs round-trip;ListBackendNames→["s3"]; state-RPC-before-Configure→FailedPrecondition🤖 Generated with Claude Code