feat: typed-IaC conformance migration to v1.0.0 (issue #8)#11
Merged
Conversation
Mirror DO v1.0.1 force-cutover pattern: sdk.ServeIaCPlugin, awsIaCServer wrapping AWSProvider, workflow bump to v0.51.7, version bump to v1.0.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Specify DetectDriftWithSpecs as thin delegator to DetectDrift - Add atomicity note: Phase 2+4 deletions must be one commit - Add go.mod bump verification gate (go mod tidy + go build) - Add host_conformance_test rewrite spec (service-kind + live RPCs) - Clarify Unimplemented embed vs. auto-registered services - Add rollback go.sum note - Expand assumptions for plugin.contracts.json and API bump Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
7-task single-PR plan: workflow bump, iacserver, resourcedriver_server, entrypoint cutover, metadata bump, host_conformance rewrite, final verification. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/iacserver.gowithawsIaCServerstruct satisfyingpb.IaCProviderRequiredServer,pb.IaCProviderDriftDetectorServer, andpb.ResourceDriverServerinternal/resourcedriver_server.gowith per-type CRUD dispatch delegating to*AWSProvider.ResourceDriversdk.Serve/PluginProviderstring-dispatch surface (plugin.go,module.go,plugin_test.go)host_conformance_test.goto validate typed-IaC load path (service-kind contract + live RPC)Fixes
Closes #8
Test plan
go test ./... -racepassesWORKFLOW_IAC_HOST_CONFORMANCE=1 go test ./internal/ -run TestWorkflowHostConformancepassesgo build ./cmd/workflow-plugin-awsexits 0GOOS=linux GOARCH=amd64 go build+GOOS=darwin GOARCH=arm64 go buildpassBreaking change
Old workflow engine tags (pre-v0.51.0) are permanently incompatible. Consumers must pin
workflow-plugin-aws@v1.0.0and use a workflow engine at v0.51.0+.🤖 Generated with Claude Code