fix(passkey): accept base64url credential ids#48
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes passkey login failures caused by silently ignored JSON/base64 decode errors by introducing a plugin-owned credential JSON decoder that accepts both standard base64 and base64url (padded or raw) for credential byte fields, and by making begin/finish login fail cleanly on malformed credential JSON.
Changes:
- Added
parsePasskeyCredentialsplus supporting JSON structs and base64/base64url decoding helpers in the passkey step implementation. - Updated passkey login begin/finish to use the new decoder and surface parsing failures instead of ignoring
json.Unmarshalerrors. - Added focused unit tests covering base64url IDs, standard base64 IDs, and invalid IDs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/step_passkey.go |
Adds a strict, base64url-aware credential JSON decoder and wires it into passkey begin/finish login paths. |
internal/step_passkey_test.go |
Adds unit tests validating the new decoder behavior for base64/base64url and malformed input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The plugin emits passkey credential IDs with base64url encoding from registration, but login parsed credential JSON into []webauthn.Credential using Go's default []byte JSON decoder, which only accepts standard base64. Decode errors were ignored, so supplied credentials could become unusable and the browser ceremony would fail or hang downstream.
Verification
With URL-safe decoding temporarily removed:
With fix restored:
Full suite: