fix: preserve admin auth effective config#47
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the strict-typed (protobuf) step handling for step.auth_admin_config_describe so admin-auth “effective_config” is preserved through typed execution, while also preventing unrelated pipeline/request data (e.g., headers) from being echoed back in describe outputs.
Changes:
- Add a dedicated typed handler for
step.auth_admin_config_describethat can recover effective admin-auth config from prior step outputs during describe-only flows. - Introduce an allowlist for admin-auth config keys to ensure only intended configuration fields can appear in
effective_config/accepted_config. - Add a regression test ensuring effective config is preserved and request headers are not leaked.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/typed.go | Adds a custom typed handler for admin config describe and merges recovered config into the typed current. |
| internal/step_admin_config.go | Replaces ad-hoc sanitization with an allowlisted key filter; adds helpers to recover safe config keys from step outputs. |
| internal/plugin.go | Switches the typed step factory wiring for step.auth_admin_config_describe to the new handler. |
| internal/plugin_contracts_test.go | Adds a typed regression test for preserving effective_config while preventing header leakage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests