fix(auth): add admin passkey toggle#45
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an explicit admin/policy toggle to disable passkey authentication without requiring WebAuthn relying party configuration to be cleared, and extends the plugin’s strict proto contracts to include the new inputs.
Changes:
- Add
passkey_auth_enabled/passkey_enabledinputs and treat strictfalseas a hard disable for passkeys (while still requiring RP config to be present to enable). - Expose
passkey_auth_enabledas an admin config control and skip RP validation when passkeys are explicitly disabled. - Extend protobuf contracts (and generated code) and add/update regression tests and changelog entry.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/step_methods_policy.go | Adds passkey “configured vs enabled” split and introduces strict-false parsing helpers. |
| internal/step_methods_policy_test.go | Adds regression coverage for disabling passkeys (needs additional cases per review). |
| internal/step_admin_config.go | Exposes passkey toggle in admin controls and bypasses RP validation when disabled. |
| internal/step_admin_config_test.go | Updates admin describe test to include/verify the new toggle control. |
| internal/contracts/auth.proto | Adds optional proto fields for passkey toggle inputs/config. |
| internal/contracts/auth.pb.go | Regenerates Go bindings for the updated proto contracts. |
| CHANGELOG.md | Documents the new passkey toggle behavior. |
Files not reviewed (1)
- internal/contracts/auth.pb.go: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification