Skip to content

chore: apply plugin version discipline#13

Merged
intel352 merged 1 commit into
mainfrom
issue-760-version-discipline
Jun 1, 2026
Merged

chore: apply plugin version discipline#13
intel352 merged 1 commit into
mainfrom
issue-760-version-discipline

Conversation

@intel352
Copy link
Copy Markdown
Contributor

@intel352 intel352 commented Jun 1, 2026

Part of GoCodeAlone/workflow#760.

Changes:

  • keep committed plugin.json.version at the 0.0.0 development sentinel
  • add post-build release validation so the shipped manifest is checked against the tag

Verification:

  • wfctl plugin validate-contract .
  • wfctl plugin validate-contract --for-publish --tag v9.9.9 .
  • GOWORK=off go test ./...

Copilot AI review requested due to automatic review settings June 1, 2026 17:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Applies the "plugin version discipline" pattern: the committed plugin.json keeps the 0.0.0 development sentinel, and the release workflow gains a post-build check that the shipped manifest matches the pushed tag.

Changes:

  • Reset plugin.json version to the 0.0.0 development sentinel.
  • Add a post-build validate-contract --for-publish --tag ... --release-dir . step in release.yml to verify the shipped manifest carries the release tag.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
plugin.json Set version to the 0.0.0 sentinel so the committed manifest no longer encodes a release version.
.github/workflows/release.yml Add post-build validate-contract step that asserts the shipped manifest matches github.ref_name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@intel352 intel352 merged commit 7c87620 into main Jun 1, 2026
5 checks passed
@intel352 intel352 deleted the issue-760-version-discipline branch June 1, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants