Skip to content

chore: apply plugin version discipline#12

Merged
intel352 merged 1 commit into
mainfrom
issue-760-version-discipline
Jun 1, 2026
Merged

chore: apply plugin version discipline#12
intel352 merged 1 commit into
mainfrom
issue-760-version-discipline

Conversation

@intel352

@intel352 intel352 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Part of GoCodeAlone/workflow#760.

Changes:

  • keep committed plugin.json.version at the 0.0.0 development sentinel
  • remove the obsolete sync-plugin-version workflow
  • add post-build release validation so the shipped manifest is checked against the tag

Verification:

  • wfctl plugin validate-contract .
  • wfctl plugin validate-contract --for-publish --tag v9.9.9 .
  • GOWORK=off go test ./...

Copilot AI review requested due to automatic review settings June 1, 2026 17:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enforces plugin version discipline by keeping the committed plugin.json at the 0.0.0 development sentinel, removing the now-obsolete tag-sync workflow, and adding a post-build validation step that verifies the shipped manifest matches the release tag.

Changes:

  • Reset plugin.json version from 0.1.2 to the 0.0.0 development sentinel.
  • Delete the sync-plugin-version.yml workflow that previously opened PRs to bump plugin.json on tag pushes.
  • Add a post-build wfctl plugin validate-contract --for-publish --tag ... step in release.yml.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
plugin.json Resets version to 0.0.0 sentinel so the committed manifest no longer claims a release version.
.github/workflows/sync-plugin-version.yml Removes the obsolete workflow that auto-synced plugin.json from release tags.
.github/workflows/release.yml Adds post-build validation that the shipped manifest carries the release tag.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@intel352 intel352 merged commit d6d7b39 into main Jun 1, 2026
5 checks passed
@intel352 intel352 deleted the issue-760-version-discipline branch June 1, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants