ci: canonical registry notify (fix dead dispatch + drop manifest-overwrite)#11
Merged
Merged
Conversation
Fixes dead dispatch: the workflow-registry resolver rejects an
owner/repo payload like "GoCodeAlone/workflow-plugin-analytics"; it
expects a bare plugin name. Switch client-payload to {"plugin":
"analytics", ...}.
Also drops the regressing direct manifest-write pattern (none present
here, but the old notify-registry job used a non-pinned action SHA and
REGISTRY_PAT). Replaces with fleet-canonical notify-workflow-registry
job: pinned peter-evans/repository-dispatch@28959ce8... (v4),
repo_dispatch_token secret, pre-release guard (!contains ref_name '-'),
repository scoped to this plugin.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the release workflow’s registry notification to match the workflow-registry “canonical” dispatch pattern and fixes the dispatch payload so the registry resolver receives the expected bare plugin name.
Changes:
- Renames and tightens the registry notification job (
notify-workflow-registry) with repository scoping and a pre-release guard. - Pins
peter-evans/repository-dispatchto a v4 commit SHA and switches tosecrets.repo_dispatch_token. - Fixes
client-payloadto send"plugin": "analytics"instead of the full${{ github.repository }}.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the dead registry dispatch: the old
notify-registryjob sent{"plugin": "GoCodeAlone/workflow-plugin-analytics", ...}but the workflow-registry resolver expects a bare plugin name. Now sends{"plugin": "analytics", ...}.Also modernises to the fleet-canonical pattern:
peter-evans/repository-dispatch@28959ce8...(v4)repo_dispatch_tokensecret (replacesREGISTRY_PAT)!contains(github.ref_name, '-'))ifcondition