Skip to content

ci: make module releases compatible with immutable releases#108

Merged
intel352 merged 1 commit into
mainfrom
chore/immutable-module-release-workflow
May 6, 2026
Merged

ci: make module releases compatible with immutable releases#108
intel352 merged 1 commit into
mainfrom
chore/immutable-module-release-workflow

Conversation

@intel352
Copy link
Copy Markdown
Contributor

@intel352 intel352 commented May 6, 2026

Summary

  • remove post-publish release asset upload/delete from module-release workflow
  • keep module release/tag creation and Go proxy announcement flow intact
  • avoid GitHub immutable-release 422 failures caused by mutating release assets after publish

Verification

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/module-release.yml"); puts "yaml ok"'
  • git diff --check
  • actionlint scoped check for edited release block produced no findings

Full actionlint still reports pre-existing shellcheck warnings elsewhere in module-release.yml.

Copilot AI review requested due to automatic review settings May 6, 2026 21:00
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the module release GitHub Actions workflow to be compatible with GitHub “immutable releases” by removing post-publish release asset mutations while preserving the existing release/tag creation and Go proxy announcement behavior.

Changes:

  • Remove post-publish gh release upload and gh release delete-asset steps to avoid immutable-release 422 failures.
  • Keep release creation, git tag creation/push, and Go proxy announcement flow intact.
  • Minor hardening/readability improvements by assigning key values to variables and consistently quoting them.

@intel352 intel352 merged commit 8015437 into main May 6, 2026
12 checks passed
@intel352 intel352 deleted the chore/immutable-module-release-workflow branch May 6, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants