fixed resetCurrentXp being overridden on respawn causing xp duplication#440
Open
uema5a wants to merge 1 commit into
Open
fixed resetCurrentXp being overridden on respawn causing xp duplication#440uema5a wants to merge 1 commit into
uema5a wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! First off, thanks for maintaining LevelZ — it's been a lot of fun to play with. I ran into a bug and wanted to contribute a fix!
Summary
resetCurrentXp=truewithlevelRetainPercentage=100(default) caused XP duplication on deathRoot Cause
In the
AFTER_RESPAWNhandler, the reset block ran beforeupdatePlayerSkills(newPlayer, oldPlayer), which internally callssetLevelProgress(oldLevelManager.getLevelProgress())and overwrites the reset. As a result, the player dropped aLevelExperienceOrbEntitybut kept their full progress — pure XP duplication.Fix
Moved the
resetCurrentXpreset block inside theelsebranch, afterupdatePlayerSkills, so the reset is applied after the state copy and cannot be overwritten.