Open
Conversation
Gjum
reviewed
Feb 24, 2026
Owner
There was a problem hiding this comment.
Is this still correct? I believe the UUID and token may have been flipped in 1.21.11?
Gjum
reviewed
Feb 24, 2026
|
|
||
| private void save() { | ||
| try { | ||
| Files.writeString(FAVORITES_FILE, gson.toJson(favoriteKeys)); |
Owner
There was a problem hiding this comment.
How do we prevent a race condition here? If this is called from two threads, a corrupt file may be written.
Gjum
reviewed
Feb 24, 2026
Owner
|
please rebase onto the main branch |
Gjum
reviewed
Feb 24, 2026
| public static @NotNull String keyOf(@NotNull Exchange exchange) { | ||
| return exchange.pos.server + "|" + exchange.pos.world + "|" | ||
| + exchange.pos.x + "|" + exchange.pos.y + "|" + exchange.pos.z | ||
| + "|" + exchange.index; |
Owner
There was a problem hiding this comment.
Is there a particular reason why index is part of the favorite key? If some trades before a favorite are removed from a chest, is it no longer a favorite?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a "Favourite" button and "Star" buttons next to exchanges.
Every Exchange now has a "Star" button if that button is pressed that particular exchange is marked as "Favourite"
in the GUI you can differentiate between showing Everything or Showing exchanges you have Favourited.
Supports showing search results in game meaning if you have Show: Favourite selected and show search results in game only said favourites will be shown in game.
Favourites are persistend between sessions.