fix: add android platform support for Termux npm install

[anandh8x]

Summary

npm install -g @gitlawb/zero failed on Android/Termux with EBADPLATFORM because package.json's os array did not include "android". Termux provides a Linux userspace on the Linux kernel — the existing linux-arm64 binary works natively.

Changes

1. package.json — Added "android" to the os array.
2. scripts/postinstall.mjs — Mapped android to linux in resolvePlatform(), so the postinstall downloads the correct linux-arm64 binary.

Verified by the reporter on Termux (Unihertz Titan 2, Android 11, aarch64): postinstall succeeds and zero --help runs correctly.

Fixes #449

Summary by CodeRabbit

• New Features
  • Added support for Android as a recognized platform, improving compatibility for Android-based environments.
  • Android now uses the Linux prebuilt binary path, helping the app install and run more reliably on that platform.

[github-actions]

Zero automated PR review

Verdict: No blockers found

Blockers

• None found.

Validation

• [pass] Diff hygiene: git diff --check
• [pass] Tests: go test ./...
• [pass] Build: go run ./cmd/zero-release build
• [pass] Smoke build: go run ./cmd/zero-release smoke

Scope

Head: fbfc2a07faca
Changed files (2): package.json, scripts/postinstall.mjs

This deterministic review checks validation status and basic diff hygiene. A human reviewer still owns product judgment and design quality.

[coderabbitai]

Walkthrough

Adds "android" to the supported os array in package.json and extends resolvePlatform in scripts/postinstall.mjs to map the android platform to linux, allowing installation on Android/Termux to resolve the existing linux prebuilt binary.

Changes

Android platform support

Layer / File(s)	Summary
Android OS target and platform mapping package.json, scripts/postinstall.mjs	Adds android to the package os array and maps it to linux in resolvePlatform, with updated inline documentation for the ZERO_INSTALL_PLATFORM override.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Related issues: #449 — adds android to package.json os array and maps it to linux in postinstall's resolvePlatform, enabling npm install -g on Android/Termux to use the existing linux-arm64 binary.

Suggested labels: enhancement, dependencies

Suggested reviewers: Gitlawb

🐇 A hop from Linux to Termux's shore, Android joins the OS-array lore. No new binary to bake or brew— Just a mapping, tried and true. `npm install` now finds its way home once more.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding Android/Termux support for install and postinstall handling.
Linked Issues check	✅ Passed	The diff adds android to the package os allowlist and maps android to linux in postinstall, matching issue #449.
Out of Scope Changes check	✅ Passed	The PR stays narrowly focused on Android/Termux install support and does not introduce unrelated changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/termux-android-platform

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

scripts/postinstall.mjs (1)

65-77: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Mapping looks correct; add regression coverage for the new case.

android → linux fallthrough is correct and matches the PR's stated intent. The existing Go test table for resolvePlatform/asset resolution only covers linux, darwin, win32 — worth adding an android/arm64 case there so a future refactor of this switch doesn't silently regress Termux support.

Separately (non-blocking, since the author already verified zero --help on-device): Termux runs on Bionic libc rather than glibc, and dynamically-linked Linux binaries can require workarounds there. Since resolvePlatform only affects binary selection, not the binary's own linking, this is worth a mental note for future linux-arm64 build changes (e.g., switching to CGO_ENABLED=1) that could reintroduce Termux breakage without the reporter's platform showing symptoms.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/postinstall.mjs` around lines 65 - 77, Add regression coverage for
the new android platform mapping in resolvePlatform and the related
asset-resolution Go test table. Update the existing tests around
resolvePlatform/asset selection to include an android/arm64 case that verifies
android falls through to linux, using the resolvePlatform symbol and the current
platform-asset lookup helpers so future refactors don’t drop Termux support.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@scripts/postinstall.mjs`:
- Around line 65-77: Add regression coverage for the new android platform
mapping in resolvePlatform and the related asset-resolution Go test table.
Update the existing tests around resolvePlatform/asset selection to include an
android/arm64 case that verifies android falls through to linux, using the
resolvePlatform symbol and the current platform-asset lookup helpers so future
refactors don’t drop Termux support.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 78db3306-6cf5-41ce-a19b-9734d55f0630

📥 Commits

Reviewing files that changed from the base of the PR and between bdb1b0e and fbfc2a0.

📒 Files selected for processing (2)

• package.json
• scripts/postinstall.mjs

[Vasanthdev2004]

looks good for me

[kevincodex1]

LGTM

[Vasanthdev2004]

Approve — high value-to-cost platform fix

Worth it: yes, easily. Termux is the primary way people run CLI tools on Android, and it exposes a real Linux/aarch64 userspace where Zero's existing linux-arm64 binary runs natively. Before this, npm install -g @gitlawb/zero hard-failed on Termux with EBADPLATFORM solely because package.json's os array omitted "android" (#449). The fix reuses the already-published, already-checksummed linux-arm64 asset — no new build target, no new artifact, effectively zero permanent maintenance cost. Two lines in package.json, two in postinstall.mjs. Thanks @anandh8x.

Verified on Windows (worktree):

• ZERO_INSTALL_DRY_RUN=1 ZERO_INSTALL_PLATFORM=android ZERO_INSTALL_ARCH=arm64 node scripts/postinstall.mjs → correctly resolves to zero-v…-linux-arm64.tar.gz / binary zero.
• bin/zero.js zeroBinaryName() branches only win32-vs-else, so android maps to the plain zero name postinstall installs — no runtime mismatch.
• internal/npmwrapper tests pass; CI green incl. Windows smoke (no #414-class break).

Security: no new surface — download path unchanged (HTTPS-only pinned repo, SHA-256 verification against the release's own .sha256, no-zip-slip extraction). Android just selects an existing verified artifact.

Non-blocking follow-ups:

1. Add an android/arm64 row to the TestPostinstallComputesAssetPlan table so a future resolvePlatform refactor can't silently re-break Termux (CodeRabbit flagged this too).
2. The optional linux sandbox helpers (zero-linux-sandbox, zero-seccomp) are glibc/standard-kernel oriented and likely won't function under Termux's Bionic libc — so Zero runs with reduced isolation on Android. Behavior is already graceful (optional helpers + warning), but a Termux-specific "sandboxing unavailable" note would set correct expectations.

Approving.