This repository was archived by the owner on Nov 24, 2020. It is now read-only.
Added null/empty jQuery check & default top val#51
Open
kylekellogg wants to merge 1 commit intoGitbookIO:masterfrom
Open
Added null/empty jQuery check & default top val#51kylekellogg wants to merge 1 commit intoGitbookIO:masterfrom
kylekellogg wants to merge 1 commit intoGitbookIO:masterfrom
Conversation
Based on this error I get when running GitBook 3.2.2:
```
Uncaught TypeError: Cannot read property 'top' of undefined
at a (theme.js:formatted:5276)
at HTMLLIElement.<anonymous> (theme.js:formatted:5315)
at Function.each (theme.js:formatted:784)
at de.fn.init.each (theme.js:formatted:694)
at HTMLDivElement.l (theme.js:formatted:5313)
at HTMLDivElement.dispatch (theme.js:formatted:2468)
at HTMLDivElement.m.handle (theme.js:formatted:2400)
```
Accordingly, I've added
# A null check to the `while` loop of `getElementTopPosition`
# An empty jQuery element check to the `while` loop of `getElementTopPosition`
# Sensible defaults should the call to `$el.position().top` in `getElementTopPosition` fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this error I get when running GitBook 3.2.2:
Accordingly, I've added
whileloop ofgetElementTopPositionwhileloop ofgetElementTopPosition$el.position().topingetElementTopPositionfail